Skip to content

One font list entry per family, with Bold and weight controls - #8941

Merged
Frooodle merged 10 commits into
restore-document-fontfrom
font-picker-bold-toggle
Nov 18, 2026
Merged

Frooodle merged 10 commits into
restore-document-fontfrom
font-picker-bold-toggle

Conversation

@Frooodle

Copy link
Copy Markdown
Member

Description of Changes

  • The font list shows one entry per family instead of "X", "X Bold", "X Italic" for document, built-in, server and device fonts. Real PDF names are grouped: subset tags, ,/- separators, PostScript suffixes and weight words.
  • Adds a Bold toggle beside Italic. It is enabled only when the family has a real bold face, with a tooltip saying why when it is not. No faked bold.
  • Adds a weight dropdown for families with weights beyond regular and bold. A family that has only a bold face is listed under its family name with Bold locked on.
  • Picking a family keeps the text's weight and slant. Letters the new face lacks are drawn in the closest match with a warning instead of being dropped.
  • Italic now warns when it skips text it cannot change, instead of doing nothing silently.
  • Formatting controls fold into the existing Aa menu whenever they do not fit; before, they scrolled off the toolbar. Dropdowns inside the Aa menu (colour, outline, change case, family, weight) no longer close the menu when clicked.
  • Plain Helvetica shows as "Helvetica" instead of PDFium's stand-in name.
  • Stacked on Improve PDF text editor fidelity: fonts, typing, undo, scans, images and tables #8906.

Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have run task check to verify linters, typechecks, and tests pass

  • I have tested my changes locally. Refer to the Testing Guide for more details.

  • Verified in the running editor: font list, Bold toggle, weight menu and folded toolbar. Saved files contain the bold face (pdffonts shows Helvetica-Bold and LiberationSans-Bold).

  • All frontend unit tests pass (9,324), plus typecheck, lint and comment-lint.

  • Every text-editor browser test ran in Chromium, Firefox and WebKit in the CI image. Only page-load timeouts failed, and those passed on retry or alone. The new spec passed 10× in each browser.

  • Not done: bold/italic/weight apply to whole text boxes, not part of a selection. Names with no separator before the style (e.g. "LinuxLibertineGBI") are not grouped.

@Frooodle
Frooodle requested review from a team and balazs-szucs as code owners November 17, 2026 10:54
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 77c565d6-90a3-434d-9bfa-d4ee12a09194

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

📦 Tauri Desktop Builds Ready!

The desktop applications have been built and are ready for testing.

Download Artifacts:

🍎 macOS Universal: Download Stirling-PDF-macos-universal (.dmg) - 258.2 MB
🪟 Windows x64: Download Stirling-PDF-windows-x86_64 (.exe, .msi) - 207.1 MB


Built from commit 8ac213a
Artifacts expire in 7 days

@Frooodle
Frooodle merged commit 02ded8c into restore-document-font Nov 18, 2026
62 checks passed
@Frooodle
Frooodle deleted the font-picker-bold-toggle branch November 18, 2026 19:57

This branch was successfully deployed

1 active and 1 inactive deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant